]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
messageList: Fix invisible close buttons still working
authorFlorian Müllner <fmuellner@gnome.org>
Fri, 23 Feb 2018 09:27:07 +0000 (10:27 +0100)
committerFlorian Müllner <florian.muellner@gmail.com>
Fri, 2 Mar 2018 19:59:48 +0000 (19:59 +0000)
Since commit c4f2bb5f, close buttons are hidden by making them fully
transparent rather than setting their visibility to false to keep
the overall message layout stable. As a result, the buttons now work
even when invisible, which is clearly unexpected - fix this by updating
the reactive property appropriately.

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/issues/66

js/ui/messageList.js

index 61987191b381316de7246e1dc3e2c8f1ace40b61..aff201ed6fc32efab281ecca98ca40c3af29c602 100644 (file)
@@ -502,6 +502,7 @@ var Message = new Lang.Class({
     _sync() {
         let visible = this.actor.hover && this.canClose();
         this._closeButton.opacity = visible ? 255 : 0;
+        this._closeButton.reactive = visible;
     },
 
     _onClicked() {